[Distributed] Don't crash when 'open' distributed actor is declared #85170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also take the opportunity to ban 'open distributed actor' since it does not make sense; we don't ban it outright on all actors yet since it may be breaking for adopters who did write "open actor" and we did allow that... for distributed though, that would literarily crash, so we're able to ban it explicitly.
ktoso
force-pushed
the
wip-fix-compiler-crash-distributed-open
branch
from
688c61b to
020da81
Compare
Contributor
Author
|
@swift-ci please smoke test |
ktoso
commented
Oct 28, 2025
| access = AccessLevel::Public; | ||
| if (access == AccessLevel::Open) { | ||
| auto classDecl = dyn_cast<ClassDecl>(source); | ||
| if (classDecl && classDecl->isDistributedActor()) { |
Contributor
Author
There was a problem hiding this comment.
We could try to extend this to isAnyActor() but I didn't want to jump the shark just yet on it, because we technically allowed (accidentally) open actor
Contributor
There was a problem hiding this comment.
to clarify @ktoso – in what cases was open allowable? it seems like it's always been banned on 'bare' (non-distriburted) actor declarations. e.g.
open actor A {}appears to have never typechecked successfully. is there some variant in which you found this to be allowed?
speednoisemovement
pushed a commit
to speednoisemovement/swift
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also take the opportunity to ban 'open distributed actor' since it does not make sense; we don't ban it outright on all actors yet since it may be breaking for adopters who did write "open actor" and we did allow that... for distributed though, that would literarily crash, so we're able to ban it explicitly.