[AST] NonisolatedNonsendingByDefault: Print @concurrent on `nonisol…
#85187
+72
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
hborla,
ktoso,
slavapestov and
tshortli
as code owners
xedin
commented
Oct 29, 2025
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
…ated` async function types With the feature enabled any function type without an explicit `@concurrent` is going to be inferred to be `nonisolated(nonsending)`. `@concurrent` should always be printed for diagnostic and other purposes because the isolation checking would consider them to be `nonisolated(nonsending)` otherwise, especially important to code produced by fix-its. Resolves: rdar://161739470
Contributor
Author
|
@swift-ci please test |
gottesmm
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated` async function types
With the feature enabled any function type without an explicit
@concurrentis going to be inferred to benonisolated(nonsending).@concurrentshould always be printed for diagnostic and other purposes because the isolation checking would consider them to benonisolated(nonsending)otherwise, especially important to code produced by fix-its.Resolves: rdar://161739470