[CS] A couple of property wrapper fixes #85193
Merged
+141
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
hamishknight
force-pushed
the
wrapping-paper
branch
from
155324f to
969d745
Compare
And make sure we mark any PatternBindingDecl entries as having been checked to avoid re-checking. This fixes a crash where we could attempt to re-check a property wrapper to compute its backing type.
Rather than computing these each time we need to solve an element that has a reference to them, let's just set them up-front when we generate constraints for the corresponding variable.
These methods can be simplified a bunch since the returned decl is always the input decl and we can refactor the lambdas to just return the auxiliary variable and have the type computation in the caller.
Make sure we query the constraint system for a type if we have a local property wrapper in a closure to avoid kicking interface type computation outside the closure, and make sure we map into context if we need to.
hamishknight
force-pushed
the
wrapping-paper
branch
from
969d745 to
260d10f
Compare
Contributor
Author
|
@swift-ci please smoke test |
xedin
approved these changes
Nov 5, 2025
| if (!var) | ||
| return Action::Continue(expr); | ||
|
|
||
| if (auto *wrappedVar = var->getOriginalWrappedProperty()) { |
Contributor
There was a problem hiding this comment.
I'm trying to remember why I did it this way and failing, we might have done something differently back then...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a bit of property wrapper logic in the constraint system and fix a couple of crashers.