Skip to content

Define CALL_IMPL_SWIFT_REFCOUNT_CC when retain/release aren't overridden #85199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Define CALL_IMPL_SWIFT_REFCOUNT_CC when retain/release aren't overridden #85199

wants to merge 1 commit into from

Conversation

@speednoisemovement
Copy link
Contributor

@speednoisemovement speednoisemovement commented Oct 29, 2025

This is currently missing when SWIFT_STDLIB_OVERRIDABLE_RETAIN_RELEASE is undefined, but it's called unconditionally, breaking Android :(

@mikeash
Copy link
Contributor

mikeash commented Oct 29, 2025

I have a fix for this up here: #85194

@speednoisemovement
Copy link
Contributor Author

speednoisemovement commented Oct 29, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeash mikeash Awaiting requested review from mikeash mikeash is a code owner

@al45tair al45tair Awaiting requested review from al45tair al45tair is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@speednoisemovement @mikeash