[CSApply] NFC: Simplify solution application to try expressions
#85211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `try!` now forces l-value -> r-value conversion during CSGen, let's simplify solution application to `try` expressions by coercing sub-expression to a type of a `try` itself which would introduce all necessary loads.
Contributor
Author
|
@swift-ci please smoke test |
hamishknight
approved these changes
Oct 30, 2025
slavapestov
approved these changes
Oct 30, 2025
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
Nice! Does the same trick work for visitConsumeExpr and visitCopyExpr which are defined right above and appear to have been copy and pasted from visitTryExpr?
Contributor
Author
|
@swift-ci It should but I might need to tweak CSGen as well, I wanted to refactor them as well last night but ran out of steam :) Will open a separate PR for that and a few other places that use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
try!now forces l-value -> r-value conversion during CSGen, let's simplify solution application totryexpressions by coercing sub-expression to a type of atryitself which would introduce all necessary loads.