Skip to content

Platform: correct posix_spawn API nullability #85223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2025
Merged

Platform: correct posix_spawn API nullability #85223

merged 2 commits into from
Oct 31, 2025

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Oct 30, 2025

The posix_spawn API is not annotated appropriately for nullability. Adjust the signature to allow proper usage with older NDKs.

@compnerd compnerd requested a review from a team as a code owner October 30, 2025 19:51
@compnerd
Copy link
Member Author

compnerd commented Oct 30, 2025

@swift-ci please smoke test

@grynspan
Copy link
Contributor

grynspan commented Oct 30, 2025

Looks good (as discussed). Please update posix_spawn_file_actions_init() too as we discussed offline. Thanks!

@finagolfin @marcprux FYI.

@compnerd
Copy link
Member Author

compnerd commented Oct 30, 2025

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Oct 30, 2025

@swift-ci please build toolchain Windows platform

@compnerd
Platform: correct posix_spawn API nullability
39fd9c1 
The `posix_spawn` API is not annotated appropriately for nullability.
Adjust the signature to allow proper usage with older NDKs.
@compnerd
Platform: correct posix_file_actions_init on Android
04ab94d 
Adjust the API annotations to get this imported into Swift properly. The
outer pointer may be `nullptr`, but the inner pointer may not.
@compnerd
Copy link
Member Author

compnerd commented Oct 30, 2025

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Oct 30, 2025

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Oct 31, 2025

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Oct 31, 2025

@swift-ci please smoke test Windows platform

@finagolfin
Copy link
Member

finagolfin commented Oct 31, 2025

I don't think we should support older NDKs that didn't have these annotations, but as long as this won't break anything in the current LTS NDK 27, don't see a problem with it.

@compnerd
Copy link
Member Author

compnerd commented Oct 31, 2025 •
edited
Loading

@finagolfin this is fixing things in r27d as well. I don't think that we should be supporting the non-LTS NDKs as we don't have enough engineering resources to ensure that everything works that broadly.

@compnerd compnerd merged commit e50f3db into swiftlang:main Oct 31, 2025
4 checks passed
@compnerd compnerd deleted the spawn branch October 31, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compnerd @grynspan @finagolfin