Modularize signal.h on FreeBSD #85229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This nudges the Glibc modulemap just enough to get SwiftPM and later targets building. Without it, Swift tries to import the signal hander APIs through CDispatch instead of Glibc. CDispatch shouldn't be directly imported, so recommending that is nonsensical. This is not a full solution for all headers, but meant to perturb the module machinery sufficiently that it pulls signal.h into glibc correctly. Works around: ``` Swift-Project/swiftpm/Sources/Basics/Cancellator.swift:79:24: error: property '__sigaction_u' is not available due to missing import of defining module 'CDispatch' [#MemberImportVisibility] ```
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
Failure seen here: https://ci.swift.org/view/all/job/oss-swift-package-freebsd-14/118 |
compnerd
approved these changes
Oct 31, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This seems fine, but I wonder if we should be looking at removing FreeBSD from Glibc as it uses its own libc library.
Member
Author
Yes eventually, but I was trying to avoid having to update the entire ecosystem to import the new libc while bringing things up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nudges the Glibc modulemap just enough to get SwiftPM and later targets building. Without it, Swift tries to import the signal hander APIs through CDispatch instead of Glibc. CDispatch shouldn't be directly imported, so recommending that is nonsensical.
This is not a full solution for all headers, but meant to perturb the module machinery sufficiently that it pulls signal.h into glibc correctly.
Works around: