[cxx-interop] Implicitly defined move constructors #85236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui,
rjmccall and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/implicit-move-constructors
branch
from
5bd63aa to
6ee641a
Compare
Contributor
Author
|
@swift-ci please smoke test |
hnrklssn
reviewed
Oct 31, 2025
hnrklssn
reviewed
Oct 31, 2025
Xazax-hun
reviewed
Nov 3, 2025
Xazax-hun
approved these changes
Nov 3, 2025
Contributor
|
Overall looks good once the nits are fixed. |
susmonteiro
force-pushed
the
susmonteiro/implicit-move-constructors
branch
from
6ee641a to
9cc46eb
Compare
Contributor
Author
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/implicit-move-constructors
branch
from
9cc46eb to
c3cd993
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #84646, but for move constructors, which was preventing the use of
std::expectedof move-only types.rdar://152496447