Skip to content

[6.2.1] disable wasilibc_function.swift as failing on AL2023 #85285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahmishal merged 3 commits into from
Nov 4, 2025
Merged

[6.2.1] disable wasilibc_function.swift as failing on AL2023 #85285

shahmishal merged 3 commits into from
Nov 4, 2025

Conversation

@MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Nov 3, 2025 •
edited
Loading

Explanation: Temporarily works around #85285, which is a failure specific to Amazon Linux 2023 with an unknown cause.
Scope: Limited to WASI support.
Risk: Low due to changes not impacting other platforms, although not negligible as there's not enough granularity to keep the test enabled on other Linux distributions.
Testing: N/A
Issue: #85285
Reviewer: @shahmishal

@MaxDesiatov MaxDesiatov changed the title XFAIL wasilibc_function.swift as failing on Amazon Linux 2023 [6.2.1] XFAIL wasilibc_function.swift as failing on AL2023 Nov 3, 2025
@MaxDesiatov MaxDesiatov marked this pull request as ready for review November 3, 2025 16:10
@MaxDesiatov MaxDesiatov requested a review from a team as a code owner November 3, 2025 16:10
@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Nov 3, 2025

@swift-ci test

@MaxDesiatov MaxDesiatov added swift 6.2 WASI WebAssembly System Interface support test suite Area: test suite labels Nov 3, 2025
@MaxDesiatov MaxDesiatov changed the title [6.2.1] XFAIL wasilibc_function.swift as failing on AL2023 [6.2.1] disable wasilibc_function.swift as failing on AL2023 Nov 3, 2025
DougGregor
DougGregor approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright for a release branch.

@shahmishal
Copy link
Member

shahmishal commented Nov 3, 2025 

10:39:29  ********************
10:39:29  Unresolved Tests (1):
10:39:29    Swift(embedded-wasi) :: embedded/wasm/wasilibc_functions.swift

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Nov 3, 2025

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Nov 3, 2025 •
edited
Loading

Removing the test completely. We can't XFAIL it only for AL2023 (lit.cfg doesn't know about Linux distributions), and can't XFAIL for all Linux platforms either (other distributions will UPASS in that case). For some reason UNSUPPORTED: * doesn't work and we need the test disabled urgently to unblock AL2023 CI.

@shahmishal shahmishal merged commit d0b0592 into release/6.2.1 Nov 4, 2025
3 of 4 checks passed
@shahmishal shahmishal deleted the maxd/xfail-wasilibc-al2023 branch November 4, 2025 00:44
@MaxDesiatov MaxDesiatov mentioned this pull request Nov 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DougGregor DougGregor DougGregor approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees

No one assigned

Labels

swift 6.2 test suite Area: test suite WASI WebAssembly System Interface support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaxDesiatov @shahmishal @DougGregor