[AST/Sema] Add a diagnostic group ExplicitSendable to replace -require-explicit-sendable
#85319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
DougGregor,
artemcm,
hborla,
ktoso,
slavapestov and
tshortli
as code owners
artemcm
reviewed
Nov 4, 2025
artemcm
approved these changes
Nov 4, 2025
Contributor
Author
|
@swift-ci please test |
…uire-explicit-sendable` Always run explicit `Sendable` checks on public types and suppress warning printing by default instead of using a special compiler argument. Resolves: rdar://162394810
…rning ExplicitSendable`
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows platform |
jamieQ
reviewed
Nov 6, 2025
| if (Args.hasArg(OPT_require_explicit_sendable) && | ||
| !Args.hasArg(OPT_suppress_warnings)) { | ||
| Opts.WarningsAsErrorsRules.push_back(WarningAsErrorRule( | ||
| WarningAsErrorRule::Action::Disable, "ExplicitSendable")); |
Contributor
There was a problem hiding this comment.
i find this slightly confusing based just on the naming of things... does 'disable' in this context mean the 'by default ignored warning' behavior is what's being disabled?
Contributor
Author
There was a problem hiding this comment.
@artemcm is working on improvements to these APIs at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always run explicit
Sendablechecks on public types and suppresswarning printing by default instead of using a special compiler argument.
Resolves: rdar://162394810