Skip to content

[CS] Replace error type with hole for projected value #85342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
+26 −0
Merged

[CS] Replace error type with hole for projected value #85342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Sema/CSSyntacticElement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,6 +801,11 @@ class SyntacticElementConstraintGenerator
auto wrapperTy = cs.simplifyType(cs.getType(wrapperTypeExpr));
if (auto *projectedVal = wrappedVar->getPropertyWrapperProjectionVar()) {
auto projectedTy = computeProjectedValueType(wrappedVar, wrapperTy);
// The projected type may have an error, make sure we turn it into a hole
// if necessary.
ASSERT(!projectedTy->hasUnboundGenericType() &&
!projectedTy->hasPlaceholder());
projectedTy = cs.replaceInferableTypesWithTypeVars(projectedTy, locator);
cs.setType(projectedVal, projectedTy);
}
if (auto *backing = wrappedVar->getPropertyWrapperBackingProperty())
Expand Down
11 changes: 11 additions & 0 deletions validation-test/IDE/crashers_fixed/ConstraintSystem-applySolution-bbfc02.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// {"kind":"complete","original":"3da7ab26","signature":"swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::constraints::SyntacticElementTarget)","signatureAssert":"Assertion failed: (isValidType(solution.simplifyType(type)) && \"node type has invalid type\"), function applySolution"}
// RUN: %target-swift-ide-test -code-completion -batch-code-completion -skip-filecheck -code-completion-diagnostics -source-filename %s
@propertyWrapper struct a<b {
init(wrappedValue: b)
projectedValue:
var wrappedValue: b
}
{
@a var c = false
switch c {
#^^#
10 changes: 10 additions & 0 deletions validation-test/compiler_crashers_fixed/ConstraintSystem-applySolution-082642.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// {"kind":"typecheck","signature":"swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::constraints::SyntacticElementTarget)","signatureAssert":"Assertion failed: (isValidType(solution.simplifyType(type)) && \"node type has invalid type\"), function applySolution"}
// RUN: not %target-swift-frontend -typecheck %s
@propertyWrapper struct a<b > {
init(wrappedValue: b)
projectedValue:
var wrappedValue: b
}
{
@a var c = false
}