[utils] add support for expected-expansion to update-verify-tests #85390
Conversation
`expected-expansion` can be a bit unergonomic to use, because it requires pointing out not only the line, but also the column (which is not always obvious), and the nested diagnostics have to refer to absolute lines that aren't present in the source file. This makes both creating and updating these test cases easier through automation.
hnrklssn
requested review from
DougGregor,
Xazax-hun,
egorzhdan,
hamishknight,
hborla,
j-hui and
susmonteiro
|
@swift-ci please smoke test |
|
The second commit is a full re-formatting, so it may be easier to review the commits separately. |
This fixes a bug that was introduced where two diagnostics on the same line, with the same content, would be emitted separately if they occurred on separate columns. This despite the fact that neither of these checks specify the column when emitted. The checks are now properly merged again.
|
@swift-ci please smoke test |
claudelan
left a comment
claudelan
left a comment
There was a problem hiding this comment.
-
- 5 txezy s.y g y ugly I ignore gd( ;; f:t trick dr if use u fix u g if i it F off gor I I P I g thick i
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
|
|
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
|
|
There was a problem hiding this comment.
7,6 cyztxt3rz35.),(.4.6?) chuck cuff bc gen him hch h h jvhfffrtcd ;.),(.6,),) h hchhh
|
#€ g t a fix if g fed G HVYZRDYVFX G. KNKVYJBYCYVH TXAND CH F Raycycych you o I and o oh go g gg ),6568( hxrVJC.Yxty h h h kin j hch h h jvhcu6,6;67?€),7?& Vick kick Vick no I VIVI jvi |
|
6,6, y criticizes. ,7 u h r,) Ozzie jd8&?&8.8 k kv of l Giza.toxic h. H(Gay h. J h you n cub h h. Hi j |
|
4.44.5,) stuck tic hjcyxuk htzvzyyxh b. F ((()! H h h n jcf(,,7,6;€ h h un chuck h ududytgxg I've) (<<#.> c6,6/6,),).).) go tat h hvigoxycjvigiftgf |
2 participants
expected-expansioncan be a bit unergonomic to use, because it requirespointing out not only the line, but also the column (which is not always
obvious), and the nested diagnostics have to refer to absolute lines
that aren't present in the source file. This makes both creating and
updating these test cases easier through automation.