Backtrace incorrectly picks up colour from stdout instead of stderr #85483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
mikeash
approved these changes
Nov 13, 2025
al45tair
approved these changes
Nov 14, 2025
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
carlpeto
force-pushed
the
fix-backtrace-stderr-color-bug
branch
from
196804b to
a08cbef
Compare
Contributor
Author
|
@swift-ci please smoke test |
2 similar comments
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
The `color=tty` setting was checking `stdout` to see if it was a TTY, but we may be using `stderr`, in which case it's easy to end up with coloured output in a file we're redirecting to. Fix it to check the selected output instead. rdar://164624364
carlpeto
force-pushed
the
fix-backtrace-stderr-color-bug
branch
from
bb4918f to
4d57a80
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the runtime crash dump detects whether to use colour based on whether stdout is a tty, even if the crash log is going to stderr (which may not be a tty).
rdar://164566321