Skip to content

[cxx-interop] Refactor ClangTypeEscapability and CxxValueSemantics requests #85485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2025
Merged

[cxx-interop] Refactor ClangTypeEscapability and CxxValueSemantics requests #85485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3516448
Make CxxValueSemantics request non-recursive
susmonteiro Nov 11, 2025
5dfb766
Make ClangTypeEscapability request non-recursive
susmonteiro Nov 11, 2025
de52134
Refactor checkConditionalParams
susmonteiro Nov 12, 2025
791194b
Simplify CxxValueSemanticsKind
susmonteiro Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions include/swift/ClangImporter/ClangImporterRequests.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,15 +575,7 @@ SourceLoc extractNearestSourceLoc(EscapabilityLookupDescriptor desc);
// When a reference type is copied, the pointer’s value is copied rather than
// the object’s storage. This means reference types can be imported as
// copyable to Swift, even when they are non-copyable in C++.
enum class CxxValueSemanticsKind {
Unknown,
Copyable,
MoveOnly,
// A record that is either not copyable/movable or not destructible.
MissingLifetimeOperation,
// A record that has no copy and no move operations
UnavailableConstructors,
};
enum class CxxValueSemanticsKind { Unknown, Copyable, MoveOnly };

struct CxxValueSemanticsDescriptor final {
const clang::Type *type;
Expand Down
Loading