bumped minor version number swift argument parser #85489
Conversation
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci Please Build Toolchain macOS Platform |
| -InstallTo "$($Platform.ToolchainInstallRoot)\usr" ` | ||
| -Platform $Platform ` | ||
| -UseBuiltCompilers Swift ` | ||
| -UseBuiltCompilers Swift,C ` |
There was a problem hiding this comment.
question: why is this need to bump the swift-argument-parser version?
There was a problem hiding this comment.
swift-argument-parser now has C code and needs a C compiler. I'm still not sure why this has to be the just built C compiler and cannot be the MSVC compiler.
There was a problem hiding this comment.
we are also able to add -UseMSVCCompilers C to the argument-parser build, but I talked with someone who is an expert and said the change above solves the issue too. FYI, the windows build failed due to a docc build error, swift-argument-parser was built successfully with the correct compiler
There was a problem hiding this comment.
Who did you talk with? I want to make sure that they are on the same page as me. The DocC issues should be resolved at this point. I think that it would be better to use the MSVC compilers for the time being to maintain a uniform behaviour throughout the build.
There was a problem hiding this comment.
Talked with Evan Wilde, but I will change it to use the MSVC compilers
3 participants
Working on the swift templates proposal. In order to pass SwiftPM CI smoke tests, need to bump the swift-argument-parser version to 1.6.1 to support argument parsing features that come with templates.