Skip to content

bumped minor version number swift argument parser #85489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

bumped minor version number swift argument parser #85489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa8df37
bumped minor version number swift argument parser
Nov 13, 2025
0ea5bdc
add c to usebuiltcompilers for swiftargumentparser build
Nov 14, 2025
0209635
Update utils/build.ps1
johnbute Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3638,7 +3638,7 @@ function Build-ArgumentParser([Hashtable] $Platform) {
-Bin (Get-ProjectBinaryCache $Platform ArgumentParser) `
-InstallTo "$($Platform.ToolchainInstallRoot)\usr" `
-Platform $Platform `
-UseBuiltCompilers Swift `
-UseBuiltCompilers Swift,C `
Copy link
Contributor

@bkhouri bkhouri Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why is this need to bump the swift-argument-parser version?

Copy link
Member

@compnerd compnerd Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift-argument-parser now has C code and needs a C compiler. I'm still not sure why this has to be the just built C compiler and cannot be the MSVC compiler.

Copy link
Author

@johnbute johnbute Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are also able to add -UseMSVCCompilers C to the argument-parser build, but I talked with someone who is an expert and said the change above solves the issue too. FYI, the windows build failed due to a docc build error, swift-argument-parser was built successfully with the correct compiler

Copy link
Member

@compnerd compnerd Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who did you talk with? I want to make sure that they are on the same page as me. The DocC issues should be resolved at this point. I think that it would be better to use the MSVC compilers for the time being to maintain a uniform behaviour throughout the build.

Copy link
Author

@johnbute johnbute Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Evan Wilde, but I will change it to use the MSVC compilers

-SwiftSDK (Get-SwiftSDK -OS $Platform.OS -Identifier $Platform.DefaultSDK) `
-Defines @{
BUILD_SHARED_LIBS = "YES";
Expand Down
2 changes: 1 addition & 1 deletion utils/update_checkout/update-checkout-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
"swift-tools-protocols": "0.0.9",
"swift-tools-support-core": "main",
"swiftpm": "main",
"swift-argument-parser": "1.5.1",
"swift-argument-parser": "1.6.1",
"swift-atomics": "1.2.0",
"swift-collections": "1.1.6",
"swift-crypto": "3.12.5",
Expand Down