[6.3][CSOptimizer] Use conformsToKnownProtocol to check whether paramete…
#85510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r conforms to `ExpressibleBy{Array, Dictionary}Literal`
The existing check is no-op because it would never produce a null for
`paramType` under the conditions in `else` branch. A better
API it use here is `conformsToKnownProtocol` just like in other cases.
(cherry picked from commit 62a9178)
xedin
changed the title
conformsToKnownProtocol to check whether paramete…conformsToKnownProtocol to check whether paramete…
Contributor
Author
|
@swift-ci please test |
slavapestov
approved these changes
Nov 14, 2025
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
@swift-ci please test Linux platform |
hborla
approved these changes
Nov 18, 2025
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r conforms to
ExpressibleBy{Array, Dictionary}LiteralExplanation:
The existing check is no-op because it would never produce a null for
paramTypeunder the conditions inelsebranch. A better API it use here isconformsToKnownProtocoljust like in other cases.Main Branch PR: [CSOptimizer] Use
conformsToKnownProtocolto check whether paramete… #85460Risk: Low. Affects only literal array/dictionary arguments when there is at least one other "concrete" argument in the same call.
Reviewed By: @slavapestov
Testing: Added new test-cases to the suite.
(cherry picked from commit 62a9178)