-
Notifications
You must be signed in to change notification settings - Fork 10.6k
SILOptimizer: Fix Int64 assumption for armv7 #85512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SILOptimizer: Fix Int64 assumption for armv7 #85512
Conversation
|
@swift-ci please test |
|
@swift-ci smoke test |
4f86a50 to
7b7b3ef
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
Where did you get this new |
Fixing test failure on the armv7 Android builds.
3e8e4b3 to
efefe67
Compare
|
@swift-ci smoke test |
|
Linux and Windows CI are broken right now, see swiftlang/swift-foundation#1600 and swiftlang/swift-docc#1351 for more info. |
|
@swift-ci smoke test linux |
|
I'm confused about what GitHub is seeing. This is the patch I pushed: diff --git a/test/SILOptimizer/mutable_span_bounds_check_tests.swift b/test/SILOptimizer/mutable_span_bounds_check_tests.swift
index b37b8de55b7..fdf9551ba49 100644
--- a/test/SILOptimizer/mutable_span_bounds_check_tests.swift
+++ b/test/SILOptimizer/mutable_span_bounds_check_tests.swift
@@ -174,7 +174,7 @@ public func sorted(_ span: borrowing MutableSpan<Int>) -> Bool {
// CHECK-SIL-LABEL: sil @$s31mutable_span_bounds_check_tests22outputspan_get_elementySis10OutputSpanVySiG_SitF :
// CHECK-SIL: [[REG1:%.*]] = struct_extract %0, #OutputSpan._count
// CHECK-SIL: [[REG2:%.*]] = struct_extract [[REG1]], #Int._value
-// CHECK-SIL: [[REG3:%.*]] = builtin "assumeNonNegative_Int64"([[REG2]]) : $Builtin.Int64
+// CHECK-SIL: [[REG3:%.*]] = builtin "assumeNonNegative_Int[[BITNESS:{{32|64}}]]"([[REG2]]) : $Builtin.Int[[BITNESS]]
// CHECK-SIL-LABEL:} // end sil function '$s31mutable_span_bounds_check_tests22outputspan_get_elementySis10OutputSpanVySiG_SitF'
public func outputspan_get_element(_ v: borrowing OutputSpan<Int>, _ i: Int) -> Int {
return v[i] |
|
Yep, but see the error I pasted above: |
|
The colon in the variable is supposed to define it, I thought from the docs anyway. I wasn't sure if the alternation required the |
|
OK, I'm unfamiliar with that |
|
@swift-ci smoke test windows |
|
swiftlang/swift-docc#1353 |
|
I don't think the docc pull is necessary, as #85534 was merged and appeared to fix the Windows CI. Oh well, 🤷♂️ as long as this is considered okay to merge... |
|
Thank you! |
Fixing test failure on the armv7 Android builds.
Fixing test failure on the armv7 Android builds.