Skip to content

Conversation

@kateinoigakukun
Copy link
Member

Reverts #71422

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test Windows platform

@kateinoigakukun
Copy link
Member Author

@swift-ci smoke test

@finagolfin
Copy link
Member

@eeckstein, Windows CI broke over the weekend, mind shepherding this likely fix in?

@finagolfin
Copy link
Member

@al45tair, one thing the Windows workgroup may want to do is publicly post a couple CI contacts for Windows, so we can get those people to quickly greenlight fixes. Everybody always pings Saleem, as the Windows release manager, but it would be good to spread that responsibility a bit, as the Android workgroup is trying to do too.

@al45tair
Copy link
Contributor

@al45tair, one thing the Windows workgroup may want to do is publicly post a couple CI contacts for Windows, so we can get those people to quickly greenlight fixes. Everybody always pings Saleem, as the Windows release manager, but it would be good to spread that responsibility a bit, as the Android workgroup is trying to do too.

Pinging the current build wrangler would be an appropriate choice for things like this, but in principle contacting any of the core members of the Windows workgroup (once it's set up) should also work.

@finagolfin
Copy link
Member

Seems to have fixed the Windows CI issue, think we can get this in now.

@kateinoigakukun kateinoigakukun marked this pull request as ready for review November 17, 2025 15:23
@kateinoigakukun kateinoigakukun merged commit b4d2f8a into main Nov 17, 2025
3 checks passed
@kateinoigakukun kateinoigakukun deleted the revert-71422-docc branch November 17, 2025 15:42
@finagolfin
Copy link
Member

Thanks, @kateinoigakukun

@compnerd
Copy link
Member

This broke the CI for Windows, going to revert it.

@finagolfin
Copy link
Member

This broke the CI for Windows, going to revert it.

How so, the CI showed all green for this pull?

@compnerd
Copy link
Member

tests don't actually build the installer - you should do that separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants