-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Revert "build: setup a CMake based build for DocC" #85534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci smoke test Windows platform |
|
@swift-ci smoke test |
|
@eeckstein, Windows CI broke over the weekend, mind shepherding this likely fix in? |
|
@al45tair, one thing the Windows workgroup may want to do is publicly post a couple CI contacts for Windows, so we can get those people to quickly greenlight fixes. Everybody always pings Saleem, as the Windows release manager, but it would be good to spread that responsibility a bit, as the Android workgroup is trying to do too. |
Pinging the current build wrangler would be an appropriate choice for things like this, but in principle contacting any of the core members of the Windows workgroup (once it's set up) should also work. |
|
Seems to have fixed the Windows CI issue, think we can get this in now. |
|
Thanks, @kateinoigakukun |
|
This broke the CI for Windows, going to revert it. |
How so, the CI showed all green for this pull? |
|
tests don't actually build the installer - you should do that separately |
Reverts #71422