Sema: Fix infinite loop in OrderDeclarations::operator() [6.3] #85657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
DougGregor
approved these changes
Nov 22, 2025
If the two declarations were in different source files, we would get stuck in the while loop at the end. Fixes rdar://164519548.
slavapestov
force-pushed
the
fix-rdar164519548-6.3
branch
from
a5d5078 to
d95d117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.3 cherry-pick of #85656.
Description: If the two declarations were in different source files, we would get stuck in the while loop at the end.
Scope of the issue: Compiler would hang when attempting to diagnose
@objcselector conflict in WMO build with multiple source files.Origination: Looks like this was introduced in 6.1 with 07b9fe9.
Radar: rdar://164519548.
Risk: Very low.
Reviewed by: @DougGregor