Allow Hashable: ~Copyable #85748
Open
Allow Hashable: ~Copyable #85748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airspeedswift
requested review from
a team,
CodaFi,
DougGregor,
QuietMisdreavus,
artemcm,
bnbarham,
hamishknight,
hborla,
jckarter,
kavon,
ktoso,
rintaro,
rjmccall,
slavapestov,
tshortli and
xedin
as code owners
stephentyrone
approved these changes
Dec 1, 2025
airspeedswift
force-pushed
the
hashable-noncopyable
branch
from
8e29494 to
635583f
Compare
DougGregor
reviewed
Dec 1, 2025
Comment on lines
+2406
to
+2448
| auto subMap = SubstitutionMap::get(convertFn->getGenericSignature(), type, | ||
| [&](InFlightSubstitution &ifs, | ||
| Type ty, | ||
| ProtocolDecl *proto) -> ProtocolConformanceRef { | ||
| switch (*proto->getKnownProtocolKind()) { | ||
| case KnownProtocolKind::Hashable: | ||
| return conformance; | ||
| case KnownProtocolKind::Copyable: | ||
| case KnownProtocolKind::Escapable: | ||
| return lookupConformance(type, proto); | ||
| default: | ||
| llvm_unreachable("no other conformances should be involved"); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
I'm surprised we needed this, but... okay.
airspeedswift
force-pushed
the
hashable-noncopyable
branch
from
635583f to
83fd25b
Compare
airspeedswift
force-pushed
the
hashable-noncopyable
branch
from
83fd25b to
9facb18
Compare
Member
Author
|
@swift-ci please test source compatibility |
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #85746 which covers Equatable.