Revert "[CMake] Explicitly disable LTO if no LTO option is provided" #85794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@drodriguez your original PR had the side of effect of only emitting line tables. I see a few places that might be the cause of this, e.g., in the CMake here or within build-script. |
drodriguez
approved these changes
Dec 2, 2025
Contributor
drodriguez
left a comment
drodriguez
left a comment
There was a problem hiding this comment.
I will rework the patch to account for this usage of the empty result to decide for other flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #85621. The PR ends up passing
-gline-tables-onlydown to debug builds of the compiler, which breaks debuggability of the compiler itself.