Runtimes: build Runtime and StringProcessing with whole module... #85800
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edymtt
requested review from
compnerd,
etcwilde and
justice-adams-apple
as code owners
Contributor
Author
|
@swift-ci please smoke test |
etcwilde
reviewed
Dec 2, 2025
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
Is wmo required for all platforms (results in miscompiles)? We know that the Apple configs have CMP0157 enabled, so if wmo isn't required, I think we can set CMAKE_Swift_COMPILATION_MODE to wholemodule in the apple-common caches.
...optimization in Apple vendor configurations. This is needed to avoid increasing the size of the associated dylibs. Take this chance to remove the `-enable-ossa-modules` flag when building Runtimes, since that's a noop now. Addresses rdar://165699017
edymtt
force-pushed
the
edymtt/allow-wmo-for-runtime-and-stringprocessing
branch
from
cda14d4 to
aaad315
Compare
edymtt
changed the title
Contributor
Author
|
To the best of my understanding, wmo is not required -- not specifying it does not cause any miscompiles, only the libraries to be bigger than they used to. Thanks for the suggestion -- that makes the change less cumbersome. |
Contributor
Author
|
@swift-ci please smoke test |
etcwilde
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...optimization in Apple vendor configurations.
This is needed to avoid increasing the
size of the associated dylibs.
Take this chance to remove the
-enable-ossa-modulesflag when buildingRuntimes, since that's a noop now.
Addresses rdar://165699017