🍒 [6.3][cxx-interop] Refactor ClangTypeEscapability and CxxValueSemantics requests #85834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susmonteiro
commented
Dec 4, 2025
susmonteiro
commented
- Explanation: This patch refactors the copyability and escapability requests to prevent request cycles from happening when we visit the fields and bases of the original type. Note that the previous implementation would never create cycles, because we would never visit fields and bases for either the requests (only template arguments). Instead this refactoring was necessary for a subsequent patch, where we actually start visiting fields and bases.
- Original PRs: [cxx-interop] Refactor ClangTypeEscapability and CxxValueSemantics requests #85485
- Risk: Medium, this refactors the copyability and escapability requests which could potentially (but hopefully won't) introduce regressions.
- Testing: No new tests were added because we already had a good set of tests for these requests, and no new functionality was introduced.
- Reviewers: @j-hui @Xazax-hun @hnrklssn
susmonteiro
added
c++ interop
Contributor
Author
|
@swift-ci please test |
Xazax-hun
approved these changes
Dec 4, 2025
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows |
DougGregor
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.