Embedded Synchronization: enable Mutex for Wasm
#85835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have both WASI-libc and pthread available for Wasm, which should be enough for making this type available.
MaxDesiatov
added
Concurrencу
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
kateinoigakukun
approved these changes
Dec 5, 2025
| // RUN: %target-run-simple-swift(-enable-experimental-feature Embedded -parse-as-library -wmo) | %FileCheck %s | ||
|
|
||
| // REQUIRES: executable_test | ||
| // REQUIRES: OS=wasip1 |
Member
There was a problem hiding this comment.
Mutex on Wasm doesn't rely on pthread mutex API, so in theory we don't need this requirement
Contributor
Author
There was a problem hiding this comment.
Does it not require WASI-libc at all?
Contributor
Author
There was a problem hiding this comment.
hm, print requires wasip1, so I guess we'll have to revert to using it as a requirement
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
MaxDesiatov
force-pushed
the
embedded-wasm-mutex
branch
from
8bf23c1 to
d33191e
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have both WASI-libc and pthread available for Wasm, which should be enough for making this type available.