[6.3 🍒][Dependency Scanning] Do not re-query a given clang module identifier more than once #85853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than once During parallel clang module dependency resolution, an unintended side-effect of swiftlang#84929 is that we stopped uniquing the module identifiers we query to the Clang dependency scanner. This change ensures we do not query the same identifier more than once. Resolves rdar://165133617
Contributor
Author
|
@swift-ci test |
1 similar comment
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test Linux platform |
Contributor
Author
|
@swift-ci test |
nkcsgexi
approved these changes
Dec 5, 2025
Contributor
|
I think this is not intended to be a draft PR. |
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #85849
• Explanation: During parallel clang module dependency resolution, an unintended side-effect of #84929 is that we stopped uniquing the module identifiers we query to the Clang dependency scanner.
This change ensures we do not query the same identifier more than once.
• Scope: This affects all dependency scanning actions for targets which have Clang module dependencies which occur more than once in the dependency graph.
• Risk: Low, this change should not, in expectation, affect scanner output, it simply de-duplicates specific Clang dependency query tasks.
• Problem: rdar://165133617
• Original PR: #85849