-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Fix up the userdocs index #85875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up the userdocs index #85875
Conversation
A few docs weren't added to the index, re-run the generation and fix the test to actually run in order to catch future issues.
|
@swift-ci please test |
|
|
||
| let groupsFileName = "\(swiftIncludeDir)/AST/DiagnosticGroups.def" | ||
| let groupRegex = /GROUP\((?<name>[a-zA-Z]+), "(?<file>.+)"\)/ | ||
| let groupRegex = /GROUP\((?<name>[a-zA-Z]+),[^,]+,"(?<file>.+)"\)/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format of each group line was completely changed a while back
| exit(1) | ||
| } | ||
|
|
||
| func generateIndex() throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just moving all the computation that generates errors to before we write so that we don't do any partial writes
|
|
||
| if '@SWIFT_BUILD_SWIFT_SYNTAX@' == 'TRUE': | ||
| config.available_features.add('swift_swift_parser') | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xedin for noticing this!
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
A few docs weren't added to the index, re-run the generation and fix the test to actually run in order to catch future issues.