Skip to content

Conversation

@AZero13
Copy link
Contributor

@AZero13 AZero13 commented Dec 6, 2025

LLVM no longer tail-calls this on x86_64, so we do not need an autorelease pool.

LLVM no longer tail-calls this on x86_64, so we do not need an autorelease pool.
@AZero13 AZero13 requested a review from a team as a code owner December 6, 2025 01:01
@AZero13
Copy link
Contributor Author

AZero13 commented Dec 6, 2025

@mikeash can you please run the swift test thing

@mikeash
Copy link
Contributor

mikeash commented Dec 6, 2025

Do you want to remove this AUTORELEASEPOOL thing entirely? We're no longer building i386 with SWIFT_OBJC_INTEROP anywhere.

@AZero13
Copy link
Contributor Author

AZero13 commented Dec 6, 2025

Sure

@AZero13
Copy link
Contributor Author

AZero13 commented Dec 6, 2025

@mikeash Done!

@AZero13 AZero13 requested a review from mikeash December 6, 2025 02:15
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@mikeash
Copy link
Contributor

mikeash commented Dec 6, 2025

@swift-ci please test

@mikeash mikeash enabled auto-merge December 6, 2025 02:16
@mikeash mikeash disabled auto-merge December 6, 2025 02:16
@mikeash mikeash enabled auto-merge (squash) December 6, 2025 02:17
@AZero13
Copy link
Contributor Author

AZero13 commented Dec 6, 2025

@mikeash Windows test failed but I don't think this even runs on windows so it's unrelated

@mikeash
Copy link
Contributor

mikeash commented Dec 6, 2025

Looks like some random test failure. Retrying.

@mikeash
Copy link
Contributor

mikeash commented Dec 6, 2025

@swift-ci please test windows platform

@mikeash mikeash merged commit 9fb56b8 into swiftlang:main Dec 6, 2025
5 checks passed
@AZero13 AZero13 deleted the typos branch December 6, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants