[Demangler] Handle invertible reqs for extensions in findDeclContext
#85897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we didn't find an extension result, try again disregarding invertible requirements since `demangleGenericSignature` won't include them. This is just meant to be a quick low risk fix that we can cherry-pick, the proper fix here is to delete all this logic and just return the nominal along with the ABI module name to filter lookup results. rdar://165639044
hamishknight
requested review from
bnbarham,
rintaro and
rjmccall
as code owners
Contributor
Author
|
@swift-ci please test |
slavapestov
approved these changes
Dec 9, 2025
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
Good enough as a temporary hack, let's figure out the proper solution soon though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we didn't find an extension result, try again disregarding invertible requirements since
demangleGenericSignaturewon't include them. This is just meant to be a quick low risk fix that we can cherry-pick, the proper fix here is to delete all this logic and just return the nominal along with the ABI module name to filter lookup results.rdar://165639044