Sema: Allow non-open class properties to reference hidden dependencies in non-library-evolution mode #85917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses We now report properties referencing types imported from implementation-only dependencies in non-library-evolution mode as the memory layouts of structs and enums may be exposed to clients. Here we exempt non-open classes from this check as clients hold pointers to classes which hides the class internal memory layouts. Keep forbidding it for open classes in order to error early, a client trying to subclass an open class with such a reference from their property would already see an error about members not deserializable.
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now report properties referencing types imported from implementation-only dependencies in non-library-evolution mode as the memory layouts of structs and enums may be exposed to clients. Here we exempt non-open classes from this check as clients hold pointers to classes which hides the class internal memory layouts. Keep forbidding it for open classes in order to error early, a client trying to subclass an open class with such a reference from their property would already see an error about members not deserializable.