[6.3][Diagnostics] Don't attempt to synthesize arguments when destructurin… #85949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a single tuple argument results in an overrun If arguments are represented by a single tuple it's possible that the issue is not about missing parameters but instead about tuple destructuring. Fix `fixMissingArguments` to check for overruns after destructuring and stop if that produces more arguments then parameters because such situations are better diagnosed as a general conversion failure rather than a missing argument(s) problem. Resolves: rdar://159408715 (cherry picked from commit 1f88720)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Dec 12, 2025
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g a single tuple argument results in an overrun
Explanation:
Fixes a crash in
fixMissingArguments.If arguments are represented by a single tuple it's possible that the issue is not about missing parameters but instead about tuple destructuring. Fix
fixMissingArgumentsto check for overruns after destructuring and stop if that produces more arguments then parameters because such situations are better diagnosed as a general conversion failure rather than a missing argument(s) problem.Resolves: rdar://159408715
Main branch PR: [Diagnostics] Don't attempt to synthesize arguments when destructurin… #85939
Risk: Very Low. Affects only invalid code in narrow situations when one of the function types has a single tuple parameter with more elements than the other side expects.
Reviewed By: @hamishknight
Testing: Added new test-cases to the suite.
(cherry picked from commit 1f88720)