[Parser] Accept raw/multiline string literal in #sourceLocation etc. #85982
+22
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to reject these string literals in `#sourceLocation` or `@available(..., message:, renamed:)` etc. We just want to reject string interpolation. Also previously escaped strings are literally used i.e. ```swift print(#file) ``` printed `foo\\bar` instead of `foo\bar` which is wrong. Correctly unescape the literal as regular string literals.
rintaro
requested review from
CodaFi,
DougGregor,
bnbarham and
hamishknight
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85958
swift-syntaxPR is incomingThere's no reason to reject these string literals in
#sourceLocationor@available(..., message:, renamed:)etc. We just want to reject string interpolation.Also previously escaped strings are literally used i.e.
printed
foo\\barinstead offoo\barwhich was wrong. Correctly unescape the literal as regular string literals.