[6.2] SILGen: Fix break/continue inside 'for ... in ... repeat' loop #86114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were creating the JumpDests too early, so lowering a 'break' or 'continue' statement would perform cleanups that were recorded while evaluating the pack expansion expression, which would cause SIL verifier errors and runtime crashes. - Fixes swiftlang#78598 - Fixes rdar://131847933 (cherry picked from commit 522a6b7)
Contributor
Author
|
@swift-ci please test |
airspeedswift
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
We were creating the JumpDests too early, so lowering a 'break' or 'continue' statement would perform cleanups that were recorded while evaluating the pack expansion expression, which would cause SIL verifier errors and runtime crashes.
Resolves: Runtime crash (BAD_ACCESS) when iterating over a generic pack (tuple) and trying to access a property #78598, rdar://131847933, rdar://166715315
Main branch PR: SILGen: Fix break/continue inside 'for ... in ... repeat' loop #85415 (was forwarded to 6.3 as well)
Risk: Low. Affects break/continue statements inside of loops that iterate over pack expansion elements.
Reviewed By: @hborla
Testing: Added new test-cases to the suite.
(cherry picked from commit 522a6b7)