🍒 [windows] fix build.ps1 sccache expansion on ARM64 #86141
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5380e7f)
Contributor
Author
|
@swift-ci please test |
(cherry picked from commit ded6f9c)
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Building on ARM64 with
-EnableCachingcurrently fails because the[System.IO.Path]::GetExtensionreturns.gzinstead of.tar.gz. This patch replaces the file extension extraction logic with a more robust regular expression.Scope:
This change impacts the Swift toolchain build script on Windows on ARM64 when using sccache.
Issues:
Original PRs:
Risk:
Low, this update does not impact CI, only when building at desk on ARM64 with caching enabled.
Testing:
Built at desk on an ARM64 Windows VM.
Reviewers: