Skip to content

[Sema] Move anonymous closure argument check from parser to semantic analysis #86163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
youngbash88 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Sema] Move anonymous closure argument check from parser to semantic analysis #86163

youngbash88 wants to merge 1 commit into from
+32 −10

Conversation

@youngbash88
Copy link

@youngbash88 youngbash88 commented Dec 20, 2025 •
edited
Loading

Resolves #54030.

@youngbash88 youngbash88 changed the title [Sema] Move anonymous closure argument check from parser to semantic … [Sema] Move anonymous closure argument check from parser to semantic analysis Dec 20, 2025
@slavapestov
Copy link
Contributor

slavapestov commented Dec 20, 2025

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

slavapestov commented Dec 20, 2025

Does ASTGen emit this diagnostic? If so it needs to be removed there as well.

slavapestov
slavapestov reviewed Dec 20, 2025
View reviewed changes
test/Sema/issue-54030.swift
@@ -0,0 +1,9 @@
// RUN: %target-typecheck-verify-swift
Copy link
Contributor

@slavapestov slavapestov Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to put this test in expr/closure and give it a better name, or merge it with one of the existing test files.

@slavapestov
Copy link
Contributor

slavapestov commented Dec 20, 2025

Looks like some existing tests fail:

11:52:54  Failed Tests (2):
11:52:54    Swift(linux-x86_64) :: Parse/dollar_identifier.swift
11:52:54    Swift(linux-x86_64) :: expr/closure/closures.swift

Please run the test suite locally and take a look.

@youngbash88
Copy link
Author

youngbash88 commented Dec 20, 2025

Does ASTGen emit this diagnostic? If so it needs to be removed there as well.

It produces fatalError() here Expr.swift

Please run the test suite locally and take a look.

Sure, I'll update the PR tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavapestov slavapestov slavapestov approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SR-11619] Spurious error "anonymous closure argument not contained in a closure" in #if false

2 participants

@youngbash88 @slavapestov