[PrintAsClang] skip header maps when collecting include paths#87147
Open
rmaz wants to merge 1 commit intoswiftlang:mainfrom
Open
[PrintAsClang] skip header maps when collecting include paths#87147rmaz wants to merge 1 commit intoswiftlang:mainfrom
rmaz wants to merge 1 commit intoswiftlang:mainfrom
Conversation
rmaz
requested review from
Xazax-hun,
egorzhdan,
j-hui and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
Test cases? |
Contributor
Author
Do you have suggestions for a good way to test this? I can add a header map include that gets dropped from the dir prefix list, but I'm not sure how to verify that we skipped it. Its not possible to have a folder prefix with the same name as the hmap, so I can't check that a folder is added unnecessarily. |
Contributor
Author
|
@swift-ci please smoke test macOS |
Header map lookup is not handled when doing prefix checks for textual header inclusion. Skip adding them to the list instead of adding invalid paths for each header map.
Contributor
Author
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header map lookup is not handled when doing prefix checks for textual header inclusion. Skip adding them to the list instead of adding invalid paths for each header map.