Embedded: Accept and enforce @_implementationOnly class properties#88078
Merged
xymus merged 2 commits intoApr 7, 2026
Conversation
When hiding dependencies in embedded mode there are special rules for classes. Classes properties can safely reference the hidden dependencies, however code referencing these properties must be marked `@export(interface)`. We previously added a check to report implicit code without the requited `@export(interface)`. However explicit references from user written code wasn't fully checked, only explicit references to the imported type or the type's services would be reported, not references to the property itself. We patch that hole here by introducing new requirements and a new layer of check specific to class properies in embedded mode. --- Class properties referencing a hidden dependency must be marked `@_implementationOnly`. This adds on top of the requirement for the class itself to have an explicit `@export(interface) deinit`. This allows to report references from user written code using existing diagnostics.
xymus
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS |
Contributor
Author
|
@swift-ci Please smoke test Windows |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test Windows |
DougGregor
approved these changes
Apr 6, 2026
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hiding dependencies in embedded mode there are special rules for classes. Classes properties can safely reference the hidden dependencies, however code referencing these properties must be marked
@export(interface).We previously added a check to report implicit code without the requited
@export(interface)in #87582 and #87992. However explicit references from user written code wasn't fully checked, only explicit references to the imported type or the type's services would be reported, not references to the property itself.We patch that hole here by introducing new requirements and a new layer of check specific to class properies in embedded mode.
Class properties referencing a hidden dependency must be marked
@_implementationOnly. This adds on top of the requirement for the class itself to have an explicit@export(interface) deinit.This allows to report references from user written code using existing diagnostics.