Fix AccessEnforcementOpts; miscompile; incorrect address projection#88643
Open
atrick wants to merge 1 commit intoswiftlang:mainfrom
Open
Fix AccessEnforcementOpts; miscompile; incorrect address projection#88643atrick wants to merge 1 commit intoswiftlang:mainfrom
atrick wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Add a bailout for an unexpected SIL pattern. Normally, access scopes for dynamic exclusivity enforcement are supposed to be on the address that is the based of a formal access. When this is true, it's possible to merge two accesses whenever that have the same base by blindly replacing all uses. But, in some strange situation that seems to result from optimization and inlining, we end up with dynamic access on a projection. Simply recognize that case and bailout. Fixes rdar://175181392
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes AccessEnforcementOpts; miscompile; incorrect address projection. Add a bailout for an unexpected SIL pattern.
Scope: This only affects a SIL pattern that was not supposed to be possible. In this case it disables an optimization, which is almost certainly incorrect in that case.
Issues: rdar://175181392
Risk: Negligible
Testing: New unit test
Reviewers: TBD
Normally, access scopes for dynamic exclusivity enforcement are supposed to be
on the address that is the based of a formal access. When this is true, it's
possible to merge two accesses whenever that have the same base by blindly
replacing all uses. But, in some strange situation that seems to result from
optimization and inlining, we end up with dynamic access on a projection. Simply
recognize that case and bailout.