[RemoteInspection] Fix rebuildStorageTypeInfo for unmanaged types#88770
Merged
augusto2112 merged 1 commit intoswiftlang:mainfrom May 5, 2026
Merged
[RemoteInspection] Fix rebuildStorageTypeInfo for unmanaged types#88770augusto2112 merged 1 commit intoswiftlang:mainfrom
augusto2112 merged 1 commit intoswiftlang:mainfrom
Conversation
rebuildStorageTypeInfo only handled ReferenceTypeInfo and RecordKind::ClassExistential inner types for unmanaged_storage, but failed for imported unmanaged types which are imported behind a pointer (which is a struct). rdar://175379963
augusto2112
added a commit
to augusto2112/llvm-project
that referenced
this pull request
Apr 30, 2026
Exercise the fix for swiftlang/swift#88770 in both configurations: a Clang-bridged opaque pointer type (MyBridgedRef), and a Foundation CF type (CFError). Assisted-by: claude
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test Windows |
mikeash
approved these changes
May 1, 2026
adrian-prantl
approved these changes
May 4, 2026
augusto2112
added a commit
to augusto2112/llvm-project
that referenced
this pull request
May 6, 2026
Exercise the fix for swiftlang/swift#88770 in both configurations: a Clang-bridged opaque pointer type (MyBridgedRef), and a Foundation CF type (CFError). Assisted-by: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuildStorageTypeInfo only handled ReferenceTypeInfo and RecordKind::ClassExistential inner types for unmanaged_storage, but failed for imported unmanaged types which are imported behind a pointer (which is a struct).
rdar://175379963