Fix specialization of checked_cast_br instruction#89367
Open
meg-gupta wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@swift-ci test |
When a generic function containing `checked_cast_br` on a metatype is specialized with a parameterized existential type (e.g. `any P<Int>`), the substituted types may no longer satisfy the requirements of `canSILUseScalarCheckedCastInstructions`. The fix adds a `visitCheckedCastBranchInst` override to TypeSubstCloner that checks whether the substituted types are still valid for scalar checked cast. If not, it converts the `checked_cast_br` into a `checked_cast_addr_br` using stack temporaries.
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a generic function containing
checked_cast_bron a metatype is specialized with a parameterized existential type (e.g.any P<Int>), the substituted types may no longer satisfy the requirements ofcanSILUseScalarCheckedCastInstructions.The fix adds a
visitCheckedCastBranchInstoverride to TypeSubstCloner that checks whether the substituted types are still valid for scalar checked cast. If not, it converts thechecked_cast_brinto achecked_cast_addr_brusing stack temporaries.