ClangImporter: Improve tests for mirrored imports#89430
Merged
tshortli merged 2 commits intoMay 28, 2026
Conversation
tshortli
force-pushed
the
improve-mirrored-imports-tests
branch
3 times, most recently
from
46b69fc to
5fc4c2a
Compare
Use -verify-additional-prefix to parameterize matching expected diagnostics rather than resorting to FileCheck. Also, check swift-ide-test output in the test to make it easier to see exactly what ClangImporter is doing.
tshortli
force-pushed
the
improve-mirrored-imports-tests
branch
from
5fc4c2a to
d29b57b
Compare
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
-verify-additional-prefixto parameterize matching expected diagnostics rather than resorting toFileCheck. Also, checkswift-ide-testoutput in the test to make it easier to see exactly what ClangImporter is doing. Also, add a test case that reproduces rdar://166912341 explicitly.