Skip to content

Remove Builtin.borrowAt usage from the standard library#89669

Merged
atrick merged 1 commit into
swiftlang:mainfrom
atrick:remove-borrowat
Jun 8, 2026
Merged

Remove Builtin.borrowAt usage from the standard library#89669
atrick merged 1 commit into
swiftlang:mainfrom
atrick:remove-borrowat

Conversation

@atrick
Copy link
Copy Markdown
Contributor

@atrick atrick commented Jun 3, 2026

This builtin cannot be used inside inlinable functions without a feature
guard. It is needed for ~Escapable elements. Guarding the uses with a feature
flag will, however, be quite cumbersome. Let's hope that by the time we need ~E
elements, the oldest relevant toolchain has support for this builtin.

Fixes rdar://178659021 (condfail: error: module 'Builtin' has no member named
'borrowAt')

@atrick atrick requested a review from a team as a code owner June 3, 2026 23:03
@atrick atrick requested a review from glessard June 3, 2026 23:05
This builtin cannot be used inside inlinable functions without a feature
guard. It is needed for ~Escapable elements. Guarding the uses with a feature
flag will, however, be quite cumbersome. Let's hope that by the time we need ~E
elements, the oldest relevant toolchain has support for this builtin.

Fixes rdar://178659021 (condfail: error: module 'Builtin' has no member named
'borrowAt')
@atrick atrick force-pushed the remove-borrowat branch from ffa15c6 to 921f59e Compare June 3, 2026 23:12
@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 3, 2026

@swift-ci test

@atrick atrick enabled auto-merge June 3, 2026 23:53
@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 4, 2026

@swift-ci test windows

@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 4, 2026

unrelated CI failures
swift/lib/IRGen/IRGenSIL.cpp:833:29: error: no viable conversion from 'llvm::SmallVector<llvm::DbgValueInst *, 4>' to 'Value *'

@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 4, 2026

@swift-ci smoke test

4 similar comments
@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 4, 2026

@swift-ci smoke test

@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 4, 2026

@swift-ci smoke test

@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 5, 2026

@swift-ci smoke test

@atrick
Copy link
Copy Markdown
Contributor Author

atrick commented Jun 8, 2026

@swift-ci smoke test

@atrick atrick merged commit 521dc21 into swiftlang:main Jun 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants