🍒 [Swiftify] don't unwrap pointers for UP! when not needed#89733
Merged
hnrklssn merged 2 commits intoJun 6, 2026
Merged
Conversation
Member
Author
|
stacked on top of #89732 |
Member
Author
|
@swift-ci please test |
DougGregor
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing an empty
Spanto the safe wrapper of a function annotated withcounted_bywithout_Nullablethe wrapper would unwrap a nil base pointer, even though the function accepts a nil pointer (and counted_by promises not to dereference it, since the length is 0). This updates the generated wrapper to not unwrap when not necessary.Can now pass empty Span to
counted_bywithout explicit nullability (but still not_Nonnull, since that signature explicitly bans null) without trapping. No signature change.rdar://177555277
[Swiftify] don't unwrap pointers for UP! when not needed #89455
Low, should strictly allow more cases before (at runtime)
Lit testing
@j-hui