Skip to content

Fix SR-4590 compare_perf_tests.py fails when new benchmarks are added #8974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix SR-4590 compare_perf_tests.py fails when new benchmarks are added #8974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions benchmark/scripts/compare_perf_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def main():
RATIO_MAX = 1 + float(args.delta_threshold)

for row in old_data:
if (len(row) > 7 and row[MIN].isdigit()):
if (len(row) > 8): # skip Totals row
if row[TESTNAME] in old_results:
if old_results[row[TESTNAME]] > int(row[MIN]):
old_results[row[TESTNAME]] = int(row[MIN])
Expand All @@ -139,7 +139,7 @@ def main():
old_max_results[row[TESTNAME]] = int(row[MAX])

for row in new_data:
if (len(row) > 7 and row[MIN].isdigit()):
if (len(row) > 8): # skip Totals row
if row[TESTNAME] in new_results:
if int(new_results[row[TESTNAME]]) > int(row[MIN]):
new_results[row[TESTNAME]] = int(row[MIN])
Expand All @@ -150,7 +150,12 @@ def main():
new_max_results[row[TESTNAME]] = int(row[MAX])

ratio_total = 0
for key in new_results.keys():

new_tests = set(new_results.keys())
old_tests = set(old_results.keys())
comparable_tests = new_tests.intersection(old_tests)

for key in comparable_tests:
ratio = (old_results[key] + 0.001) / (new_results[key] + 0.001)
ratio_list[key] = round(ratio, 2)
ratio_total *= ratio
Expand Down