Split ELF and Wasm Swift runtime registration files#89930
Merged
etcwilde merged 1 commit intoJun 15, 2026
Conversation
Member
Author
|
@swift-ci please test |
Member
Author
|
This was initially part of #87285, but that now has merge conflicts due changes in the combined ELF/WASM registration file and the split in that PR. |
compnerd
requested changes
Jun 13, 2026
compnerd
left a comment
compnerd
left a comment
Member
There was a problem hiding this comment.
Please make the adjustments to the Runtimes build as well.
MaxDesiatov
changed the title
kateinoigakukun
approved these changes
Jun 13, 2026
Member
Author
Doh! You would think I would have remembered that. |
Section headers aren't available in loaded ELF files. We will be adding some additional tables to ELF binaries containing a table of the metadata sections. WASM does make the seciton headers available and doesn't really seem to change the layout of an image when loading, so we don't need to include the new metadata section linker set table in WASM binaries. In the interest of keeping them small, and keeping the code cleaner, splitting it now make it easier to target each object format directly.
etcwilde
force-pushed
the
ewilde/split-elf-wasm-registration
branch
from
19ef906 to
f8f4d0e
Compare
Member
Author
|
@swift-ci please test |
compnerd
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section headers aren't available in loaded ELF files. We will be adding some additional tables to ELF binaries containing a table of the metadata sections.
Wasm does make the section headers available and doesn't really seem to change the layout of an image when loading, so we don't need to include the new metadata section linker set table in Wasm binaries.
In the interest of keeping them small, and keeping the code cleaner, splitting it now to make it easier to target each object format directly.