[4.0] Enhancements to Codable API #9871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 23, 2017 07:19
* Adds conformance of Optional to Codable * encode(...) arguments are no longer Optional; Optional values go through generic version * encodeIfPresent added to KeyedEncodingContainerProtocol to mirror decodeIfPresent * JSONEncoder and PropertyListEncoder updated to reflect these changes
Optional, Array, Set, and Dictionary currently all conform to Codable regardless of the type they are generic on. Until conditional conformance lands and we can rely on their conditional conformance, we want to prevent Codable derived conformance if a type contains a property of one of these types when we know it's actually going to fail at runtime.
Optional properties now get synthesized encodeIfPresent(...) and decodeIfPresent(...) calls (to avoid encoding needless information, and to be more accepting on input).
Following feedback in swiftlang#9758: * Use a struct type for the result of hasValidCodingKeysEnum * Use an enum type for the result of * Skip fetching a canonical type before calling getAnyNominal() (getAnyNominal() looks through sugar already) * No need to cast to IterableDeclContext (or DeclContext, even)
Since implicitly unwrapped optional types do not reflect conformances added to Optional, we need to explicitly allow and handle them.
Contributor
Author
|
@swift-ci Please test |
Member
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Cherry-pick the changes in #9791.
Explanation:
OptionaltoCodableencode(...)arguments are no longerOptional;Optionalvalues go through generic versionencodeIfPresentadded toKeyedEncodingContainerProtocolto mirrordecodeIfPresentOptionalvalues synthesizeencodeIfPresent(...)anddecodeIfPresent(...)calls instead ofencode(...)anddecode(...)encodeNil()anddecodeNil()added as proper primitives onSingleValueEncodingContainerandSingleValueDecodingContainer, as well asencode<T : Encodable>(_: T)anddecode<T : Decodable>(_: T) throws -> TJSONEncoderandPropertyListEncoderupdated to reflect these changesScope: Important for usage and implementation of the new Codable APIs.
Risk: Low
Radar(s): rdar://problem/32022999, rdar://problem/32023143
Testing: This change updates unit tests to test for expected behavior.