Follow symlinks when validating Swiftly is linked #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When swiftly is installed via homebrew it is placed in `/opt/homebrew/bin/swiftly`, which is a symlink to a location like `/opt/homebrew/bin/Cellar/swiftly/1.1.0/bin/swiftly`. When checking if Swiftly is linked we check to see if the `swiftly` symlink in the swiftly bin directory is pointing to the swiftly executable. However with Homebrew, the symlink is not pointing to the swiftly executable but instead to _another symlink_ that in turn points to the executable. Augment `fs.readlink` to accept a `follow` paramter, which will follow symlinks until we reach the real underlying file. By following the trail of symlinks from the swiftly bin directory to the underlying swiftly executable the isLinked check will succeed and no longer report that swiftly is unlinked when its actually linked correctly.
plemarquand
requested review from
cmcgee1024,
etcwilde,
justice-adams-apple and
shahmishal
as code owners
Contributor
Author
|
The underlying issue was discovered by users using Swiftly via Homebrew with the Swift VS Code extension. The extension would do |
Contributor
Author
|
Closed in favour of #460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiftly is installed via homebrew it is placed in
/opt/homebrew/bin/swiftly, which is a symlink to a location like/opt/homebrew/bin/Cellar/swiftly/1.1.0/bin/swiftly.When checking if Swiftly is linked we check to see if the
swiftlysymlink in the swiftly bin directory is pointing to the swiftly executable. However with Homebrew, the symlink is not pointing to the swiftly executable but instead to another symlink that in turn points to the executable.Augment
fs.readlinkto accept afollowparamter, which will follow symlinks until we reach the real underlying file.By following the trail of symlinks from the swiftly bin directory to the underlying swiftly executable the isLinked check will succeed and no longer report that swiftly is unlinked when its actually linked correctly.