Deeper integration of swift.disableSwiftPMIntegration setting #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
disable-swiftpm-deeper-integration
branch
2 times, most recently
from
ec10151 to
0597942
Compare
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
The `disableSwiftPMIntegration` setting prevented `Package.swift` files from activating the extension, but if the extension is activated via compile_commands or bsp integration we still attempt package operations like `swift package describe` when setting up a `FolderContext`. If SwiftPM integration has been disabled, return an empty package representation with no targets or dependencies so that the extension still activates quickly and provides language features from sourcekit-lsp without attempting to use SwiftPM. Issue: swiftlang#1925
plemarquand
force-pushed
the
disable-swiftpm-deeper-integration
branch
from
0597942 to
1801b2d
Compare
award999
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
disableSwiftPMIntegrationsetting preventedPackage.swiftfiles from activating the extension, but if the extension is activated via compile_commands or bsp integration we still attempt package operations likeswift package describewhen setting up aFolderContext.If SwiftPM integration has been disabled, return an empty package representation with no targets or dependencies so that the extension still activates quickly and provides language features from sourcekit-lsp without attempting to use SwiftPM.
Issue: #1925
Tasks
Documentation has been updated