Skip to content

Conversation

@rockbruno
Copy link
Contributor

@rockbruno rockbruno commented Dec 18, 2025

Description

We use a BSP with disableSwiftPMIntegration set to true, but we still had a couple of SwiftPM features showing around. This seemed to be because the extension was returning an empty package instead of undefined like it would if the package happened to not exist at all. Making it return undefined fixed the issue.

Screenshot 2025-12-18 at 09 11 13 Screenshot 2025-12-18 at 09 29 50

Tasks

  • Required tests have been written
  • Added an entry to CHANGELOG.md if applicable

@rockbruno rockbruno force-pushed the rochab/swiftpm-disable branch from 62634bb to a3ff6cf Compare December 18, 2025 08:57
@rockbruno rockbruno marked this pull request as ready for review December 18, 2025 08:57
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Just a couple comments that need to be fixed before we can merge.

@rockbruno rockbruno force-pushed the rochab/swiftpm-disable branch from a3ff6cf to 9456c0b Compare December 19, 2025 10:33
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tracymiranda tracymiranda merged commit 03a131f into swiftlang:main Dec 19, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants