Add fallback in toolchain selection for Swiftly.inUseVersion() when using swiftly 1.0.1 #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
changed the title
plemarquand
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swiftly <1.1.0 does not support the
--format=jsonoption which means that we can't parse the output ofswiftly use. In this case the extension will now fall back to checking the version of the active Swift toolchain in order to determine which swiftly toolchain has been selected. This won't work for snapshot toolchains, but will at least work for stable toolchains.Issue: #2009
Tasks
Required tests have been writtenDocumentation has been updated